Join GitHub today
deals with .xls older file extension #4200
nsoranzo left a comment
You will also have to change the line:
I have opened a PR with a variety of changes against the source branch here FredericBGA#1. @FredericBGA please have a look at the details and let me know if everything there looks okay. I'm not unwilling to drop support for legacy XLS datatype within Galaxy - I can't recall what it is used for - but the approach I PR'd would prevent us from needing to so if that is good enough we don't even need to worry about it further.
IIRC the tabular
I'm always in favor of maintaining backwards compatibility, so creating a new datatype seems the safer route here. But I don't have a specific argument for keeping the tabular based xls filetype around.
The PR by @jmchilton is required to have the
Regardless, the call to subprocess should be using an argument list, and not string formatting, since it will fail when there are e.g. spaces in the path.