Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search plugin #4213

Merged
merged 4 commits into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@anuprulez
Copy link
Member

commented Jun 21, 2017

This PR improves the search plugin (webhook) by removing the extra step of clicking on magnifier icon in the masthead to pull the resources files (script and style) into the Galaxy main application and then pressing a key combination (Ctrl + alt + q).

Now, the search overlay opens directly on the click of magnifier icon in the masthead if this plugin is activated. The necessity to press a key combination to open the search overlay is obsolete.

Please suggest if adding a key combination to open the search overlay makes it more useful?

Thanks to @joachimwolff and @bgruening!

@galaxybot galaxybot added the triage label Jun 21, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jun 21, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 22, 2017

I switched the masthead button to toggle, so it can be also closed by clicking without knowing the esc shortcut.

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 22, 2017

👍 good improvement, I actually had something like this hacked in my local Galaxy for testing, since the key shortcut was fairly hard to hit :)

edit: also big kudos for removing the JS from yaml 💯

@jmchilton jmchilton merged commit 27e843b into galaxyproject:dev Jun 22, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@anuprulez anuprulez deleted the bgruening:improve_search_plugin branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.