Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import order and Python3 compatibility for 51 files #4236

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Jun 27, 2017

xref. #1715

Also remove unused get_track_window() method of some datatypes.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

@nsoranzo Is this Travis failure legitimate?

Fix import order and Python3 compatibility for 51 files
xref. #1715

Also remove unused `get_track_window()` method of some datatypes.

@nsoranzo nsoranzo force-pushed the nsoranzo:python3 branch from d4c3088 to 6f98634 Jun 27, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2017

@jmchilton It was legitimate, rebased with the fix for lib/galaxy/work/context.py .

@jmchilton jmchilton merged commit 20ef3ee into galaxyproject:dev Jul 5, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

Very nice as always @nsoranzo - thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.