Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API repository uninstall endpoint #4248

Merged

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Jun 27, 2017

  • 58a2cde Refactors deactivate_or_uninstall_repository - Move code that deals with repository uninstallation into InstalledRepositoryManager, so that this can be reused by the API.
  • 67c6686 Adds a new API endpoint to uninstall or deactivate a repository
  • 6a8f15b Adds a basic unittest for the core InstalledRepositoryManager functionality
Refactor deactivate_or_uninstall_repository
Move code that deals with repository uninstallation into
InstalledRepositoryManager, so that this can be reused by the API.

mvdbeek added some commits Jun 27, 2017

Add `uninstall_repository` to ToolShedRepositoriesController
And connect routes. It is now possible to POST to
api/tool_shed_repositories to trigger a Repository installation and to
DELETE to api/tool_shed_repositories to uninstall a repository. In
addition one can also DELETE to
api/tool_shed_repositories/<repository_id>, which will uninstall the
repository with repository_id.

@mvdbeek mvdbeek force-pushed the mvdbeek:uninstall_repository_api_endpoint branch from 5836423 to 67c6686 Jun 27, 2017

mvdbeek added some commits Jul 2, 2017

Add basic unittest for InstalledRepositoryManager
that exercises the most basic functionality, which is the deactivate and
to uninstall repositories. Also moves shared `_init_dynamic_tool_conf`
method to BaseToolBoxTestCase

@mvdbeek mvdbeek added status/review and removed status/WIP labels Jul 4, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2017

This is ready for review. I haven't added any API tests since we don't have API tests for toolshed related API endpoints. I think these would be worth having, but I'd say this is outside of the scope of this PR.

@jmchilton jmchilton merged commit 79f3dc0 into galaxyproject:dev Jul 5, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

Fantastic - thanks a bunch!

@mvdbeek mvdbeek deleted the mvdbeek:uninstall_repository_api_endpoint branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.