Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing convention, -> util.asbool, atribute -> attribute #4250

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
5 participants
@bwlang
Copy link
Contributor

commented Jun 27, 2017

No description provided.

@galaxybot galaxybot added the triage label Jun 27, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jun 27, 2017

kwd[ 'dbkey' ] = kwd.get( 'dbkey', '?' )
kwd[ 'file_type' ] = kwd.get( 'file_type', 'auto' )
kwd['link_data_only'] = 'link_to_files' if util.string_as_bool( kwd.get( 'link_data', False ) ) else 'copy_files'
kwd[ 'link_data_only' ] = 'link_to_files' if util.asbool( kwd.get( 'link_data', False ) ) else 'copy_files'

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jun 27, 2017

Member

Is this needed to fix some bug? string_as_bool() already accepts 'true', 'yes', 'on', '1' (not case sensitive) as True.

Edit: I originally said asbool() instead of string_as_bool() in my comment above.

This comment has been minimized.

Copy link
@bwlang

bwlang Jun 28, 2017

Author Contributor

@nsoranzo : not a bug fix... but john recommended asbool, so I thought I'd make this change to match with the new code that will be next to this after my other PRs are merged

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jun 28, 2017

Member

@jmchilton Just curious, any specific reason for preferring asbool?

This comment has been minimized.

Copy link
@bwlang

bwlang Jun 29, 2017

Author Contributor

Might be nice to just do that janitorial work to coalesce to a single method...

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jul 5, 2017

Member

I don't have a particular preference - I recommended asbool in a different context at the meeting because it had a shorter name and I was more certain it exists. I generally actually use and prefer string_as_bool myself.

@jmchilton jmchilton merged commit 932b8f5 into galaxyproject:dev Jul 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

Thanks for the spelling fix and white space fix @bwlang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.