Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors tag manager to use only what it needs… #4253

Merged
merged 3 commits into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@bwlang
Copy link
Contributor

commented Jun 27, 2017

an sql_alchemy session, not the full app.
This makes it possible to use the tag manager from
the model.

refactors tag manager to use only what it needs…
an sql_alchemy session, not the full app.
This makes it possible to use the tag manager from
the model.
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

@galaxybot test this

@galaxybot galaxybot added the triage label Jun 27, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jun 27, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

@galaxybot test this

TagManager in toolshed is not related
To GalaxyTagManager
Fixes toolshed failing test
@bwlang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2017

@galaxybot test this

@bwlang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2017

looks like a transient failure... (Could not connect to ppa.launchpad.net:80 (91.189.95.83), connection timed out)
does galaxybot listen to me?
@galaxybot test this

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

@galaxybot test this

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Well, you should get automatic tests. Any idea why Jenkins is not automatically testing some PRs @martenson?

@bwlang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2017

I think that failure is probably not interesting... some deb mirror is not responding...
It passed before.
Anything needed before it can be merged?

@dannon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

@bwlang After the fix to the toolshed tag manager, this looks great to me. Thanks!

@dannon dannon merged commit 8169129 into galaxyproject:dev Jun 28, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.