Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ptkscmp datatype #4259

Merged
merged 1 commit into from Jul 4, 2017

Conversation

Projects
None yet
4 participants
@gregvonkuster
Copy link
Contributor

commented Jun 28, 2017

for PlantTribes significant components in the Ks distribution

@galaxybot galaxybot added the triage label Jun 28, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jun 28, 2017

>>> PlantTribesKsComponents().sniff(fname)
False
>>> fname = get_test_fname('1.ptkscmp')
>>> PlantTribesKsComponents().sniff(fname)

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jul 4, 2017

Member

Thanks for the tests - I think adding the tests https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/datatypes/sniff.py#L379 here instead or in addition are a bit better actually since that way the default sample config is tested as well.

@jmchilton jmchilton merged commit ac59d1d into galaxyproject:dev Jul 4, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@gregvonkuster gregvonkuster deleted the gregvonkuster:ptkscmp branch Aug 15, 2017

@martenson martenson added kind/feature and removed triage labels Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.