Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform titles #4272

Merged
merged 3 commits into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

commented Jul 2, 2017

Found myself mildly annoyed by the inability to get to the home page based on title search, so this fixes that by including the app brand in a more uniform manner.

utvalg_014

erasche added some commits Jul 2, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

Brilliant - looks good to me!

@dannon dannon merged commit 9a65d9b into galaxyproject:dev Jul 5, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@@ -1,7 +1,7 @@
<%inherit file="/base/base_panels.mako"/>

## Default title
<%def name="title()">Galaxy Tool Shed</%def>
<%def name="title()">Tool Shed</%def>

This comment has been minimized.

Copy link
@martenson

martenson Jul 5, 2017

Member

Not sure about this one.

This comment has been minimized.

Copy link
@dannon

dannon Jul 5, 2017

Member

@martenson I admittedly didn't test a local toolshed with this, but my read of it was that the "Galaxy" bit is preserved and that this doesn't change anything really. Are you seeing otherwise?

edit: If you are indeed seeing a problem here, reports was handled the same way and should also be looked at.

@martenson martenson referenced this pull request Aug 11, 2017

Closed

HTML titles mismatch #4416

@erasche erasche deleted the erasche:uniform-titles branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.