Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockquote>p sizing #4273

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
5 participants
@erasche
Copy link
Member

commented Jul 3, 2017

Noticed this styling, it was quite unattractive. I've made a change that removed it, and I'm not seeing anywhere else that uses a blockquote containing a p, other than tool help.

utvalg_015

@erasche erasche added this to the 17.09 milestone Jul 3, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

I feel like modifying bootstrap's stock less files (https://github.com/twbs/bootstrap/blob/v2.3.2/less/type.less#L196) is likely not the correct way to handle this. It seems like this will make updating against upstream bootstrap changes more difficult. Can you restrict this change to a style sheet that just affects the tool form and simply undoes the change you find visually unappealing?

@erasche

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2017

yeah, TIL galaxy_boostrap.less exists. I'll move my changes there.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

Fantastic - thanks @erasche!

@jxtx

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

@erasche erasche force-pushed the erasche:blockquotep branch 2 times, most recently from 764f1fc to 2403d50 Jul 4, 2017

@erasche erasche force-pushed the erasche:blockquotep branch from 2403d50 to eb58436 Jul 4, 2017

@erasche

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2017

should be fixed now (though not entirely sure why the JS files ended up being recompiled. Urgh)

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

@erasche

TIL galaxy_boostrap.less exists. I'll move my changes there.

really? :D

@dannon dannon merged commit eb58436 into galaxyproject:dev Jul 6, 2017

4 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@bgruening bgruening deleted the erasche:blockquotep branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.