Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package locking for node modules. #4283

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Jul 5, 2017

This may prevent some of the weirdness we have with seemingly random client rebuilds.

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

damn that's long

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2017

@martenson Took me forever to write it! ;)

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

@dannon could you please explain a bit how this works and what happens when e.g. one of the included versions becomes unreachable?

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2017

https://docs.npmjs.com/files/package-lock.json should explain most of it, but the idea is that everything used to build the client is locked to consistent versions, regardless of who's building.

*edit: regarding upgrades, or when versions are unreachable, it's easy to overwrite the lock file with a new one with a lock_delete/rebuild.

@bgruening

This comment has been minimized.

Copy link
Member

commented Jul 13, 2017

We saw this as well. Thanks @dannon let's see if this makes things better.

@bgruening bgruening merged commit 80b2f1e into galaxyproject:dev Jul 13, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.