Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackster selection grids and feature fixes #4302

Merged
merged 29 commits into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jul 11, 2017

This PR removes 5 grid related makos and restores the library dataset insertion feature of trackster. Instead of having multiple embedded grids with custom code to navigate between them, users are provided with two grids, one for history and one for library datasets. The history dataset grid allows users to sort by history names. Additionally, this PR removes the duplicate trackster insertion modal, restores the gene region parsing feature and fixes the handling of the 'select all' feature in grids by avoiding document wide dom queries.

Branched from: #4293.

@guerler guerler force-pushed the guerler:grid_trackster_selection branch from 71d1d01 to 4540a94 Jul 12, 2017

@guerler guerler added status/review and removed status/WIP labels Jul 13, 2017

@jmchilton jmchilton merged commit 69d0e21 into galaxyproject:dev Jul 13, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 13, 2017

Looks good to me - thanks @guerler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.