Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Localization Scratchbook #4307

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@manabuishii
Copy link
Contributor

commented Jul 12, 2017

No description provided.

@galaxybot galaxybot added the triage label Jul 12, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jul 12, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

@manabuishii Thanks, looks good! I'm going to go ahead and merge this and follow up with a subsequent PR adding the newly localized text to the default translation file (https://github.com/galaxyproject/galaxy/blob/dev/client/galaxy/scripts/nls/locale.js), and will rebuild the client with that. For future reference PRs, you may want to do the same.

@dannon dannon merged commit bf63ea2 into galaxyproject:dev Jul 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.