Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for loading tools when tool.lineage is None. #4317

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@blankenberg
Copy link
Member

commented Jul 14, 2017

No description provided.

@mvdbeek
Copy link
Member

left a comment

As a bugfix this looks good to me. When I'm back from vacation I'll have a look if we can't make all tools have a lineage.

@mvdbeek mvdbeek merged commit ae2fe89 into galaxyproject:dev Jul 17, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

@blankenberg how did you encounter this bug ? Were you using the watch_tools option in galaxy.ini ? In that case mvdbeek@5adc584 would fix it with the added benefit that the lineage should be properly registered.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

@mvdbeek @blankenberg Should we also add a log.warning() in the 2 changes here if tool.lineage is None?

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jul 21, 2017

If mvdbeek@5adc584 works instead of this PR I would like to undo this change, so the logging wouldn't be necessary. I think loaded tools should always have a lineage. IMO there is no good reason why some tools can't have a lineage, I just didn't think about the quick_load functionality.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 21, 2017

Fine for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.