Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the deprecated unescape() for decodeURIComponent #4321

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
4 participants

@dannon dannon requested a review from guerler Jul 17, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jul 17, 2017

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

Thanks for catching this @dannon. Definitely something we should fix. I was unaware that unescape deprecated. I remember to have tried decodeURIComponent but under certain circumstance it triggers an error if the parsed string is not a compatible. See here: https://jsfiddle.net/8jga87c7/.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@guerler Let me check that out before this is merged; I can add some error handling too, but my guess is that the example there isn't a properly encoded string.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@guerler See the encoding difference in https://jsfiddle.net/8jga87c7/2/ ? My guess, if the backbone router is encoding this stuff, is that it's doing it in a way compatible with decodeURIComponent. Have you seen an error with actual tool ids?

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

Makes sense, have not seen it with actual id's. Thanks.

@guerler guerler merged commit 4ba2b9f into galaxyproject:dev Jul 17, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@guerler Ok, cool. Let me know if we do, and I can definitely add extra error handling here.

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

Sounds good. Thanks again for catching and enhancing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.