Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print debug option from toolshed. #4332

Merged
merged 2 commits into from Jul 28, 2017

Conversation

Projects
None yet
4 participants
@davebx
Copy link
Contributor

commented Jul 21, 2017

After investigating, I've determined that it's not worth the effort to fix the print debug middleware, so this will remove the option from buildapp.py and tool_shed.ini.sample

This addresses #4330

Remove print debug option from toolshed.
After investigating, I've determined that it's not worth the effort to fix the print debug middleware, so this will remove the option from buildapp.py and tool_shed.ini.sample
@gregvonkuster

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2017

Thanks @davebx ;)

elif debug and not interactive:
# Not in interactive debug mode, just use the regular error middleware
import galaxy.web.framework.middleware.error
app = wrap_if_allowed( app, stack, galaxy.web.framework.middleware.error.ErrorMiddleware, args=(conf,) )

This comment has been minimized.

Copy link
@erasche

erasche Jul 27, 2017

Member

this won't be reached, debug = True would only enter the if debug above. Maybe else: and indent 4.

This comment has been minimized.

Copy link
@davebx

davebx Jul 27, 2017

Author Contributor

Ah crap, you're right.

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

LGTM.

@erasche erasche merged commit 79b1ad6 into galaxyproject:dev Jul 28, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.