Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default output labels for subworkflows #4346

Merged
merged 4 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Jul 27, 2017

And do not display input or input_collection modules as child workflow outputs.

Also allows to use child workflows with input modules that do not contain a label.
With these changes labels are not mandatory anymore.
This should fix #3120

I hope this makes it easier for users to get started with subworkflows.

Fix default output labels for subworkflows
And do not display input or input_collection modules as subworkflow
outputs.
This should fix #3120

@mvdbeek mvdbeek added this to the 17.09 milestone Jul 27, 2017

mvdbeek added some commits Jul 27, 2017

Change label to output_name if label is NoneType
this deals with empty strings as labels (i.e if the user has deleted a
label).

@mvdbeek mvdbeek changed the title [WIP] Fix default output labels for subworkflows Fix default output labels for subworkflows Jul 27, 2017

@mvdbeek mvdbeek added status/review and removed status/WIP labels Jul 27, 2017

@mvdbeek mvdbeek requested a review from jmchilton Jul 27, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

Very nice - this makes a lot of sense to me! Thanks a bunch as always @mvdbeek!

@jmchilton jmchilton merged commit 55ad61c into galaxyproject:dev Jul 28, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 8, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Dec 8, 2017

Provide UI collection output information for subworkflows.
This fixes galaxyproject#5158 and should provide more correct extension based connection information as well.

Includes a backport of galaxyproject#4346 which fixes galaxyproject#3120.

@mvdbeek mvdbeek deleted the mvdbeek:subworkflow_ux_improvements branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.