Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Overlay plugin bug fix #4348

Merged
merged 3 commits into from Aug 2, 2017

Conversation

Projects
None yet
4 participants
@anuprulez
Copy link
Member

commented Jul 27, 2017

This PR fixes the bug: #4247

Changes:

  • The window object Galaxy.toolPanel is replaced by Galaxy.config.toolbox_in_panel

  • Indentation fixes

Thanks @martenson!

@galaxybot galaxybot added the triage label Jul 27, 2017

@galaxybot galaxybot added this to the 17.09 milestone Jul 27, 2017

@erasche erasche added the area/UI-UX label Jul 27, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 2, 2017

@galaxybot test this

@martenson martenson merged commit f41d2ba into galaxyproject:dev Aug 2, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Aug 2, 2017

Thank you @anuprulez !

@anuprulez anuprulez deleted the bgruening:searchoverlay_bugfix branch Aug 2, 2017

@anuprulez

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2017

@martenson thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.