Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramiko based shell runner #4358

Merged
merged 4 commits into from Aug 7, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Jul 30, 2017

This introduces a new shell runner that uses paramiko for connection handling (and reuse), as well as unit testing for the SecureShell runner and the ParamikoShell runner.

For unit tests to run and pass reliably an update to paramiko is required (which is required by Fabric, which I am also updating to the latest release). Starforge PR is here.
Unit testing also requires an update to mock-ssh-server.

mvdbeek added some commits Jul 29, 2017

Sleep 100 ms before polling process
This should be long enough for most shell commands and speed up the
average time to check a job's status.
Add a new Paramiko-based shell runner and tests
This allows a single ssh connection to be reused. The unit test also
tests the current SecureShell class.
The unit tests require
[mock-ssh-server](https://github.com/carletes/mock-ssh-server). These
tests are being skipped if this library is not importable.

@mvdbeek mvdbeek added this to the 17.09 milestone Jul 30, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2017

@galaxybot test this

@mvdbeek mvdbeek force-pushed the mvdbeek:paramiko_based_shell_runner branch from 76902f7 to 69365e4 Aug 7, 2017

@mvdbeek mvdbeek changed the title [WIP] Paramiko based shell runner Paramiko based shell runner Aug 7, 2017

@mvdbeek mvdbeek added status/review and removed status/WIP labels Aug 7, 2017

@jmchilton jmchilton merged commit 31f68ed into galaxyproject:dev Aug 7, 2017

5 checks passed

api test Build finished. 280 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

Cool beans - thanks @mvdbeek!


from .local import LocalShell
from ....util import Bunch

This comment has been minimized.

Copy link
@jmchilton

jmchilton Aug 7, 2017

Member

This should probably just be galaxy.util import Bunch - not a big deal though.

@mvdbeek mvdbeek deleted the mvdbeek:paramiko_based_shell_runner branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.