Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete conda_exec_home instead of env['HOME'] #4360

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Jul 31, 2017

This should always be the same as env['HOME'] in the current code, but this feels a little safer, given that env is mutable.

Delete conda_exec_home instead of env['HOME']
This should always be the same in the current code, but this feels a
little safer, given that env is mutable.

@mvdbeek mvdbeek added this to the 17.09 milestone Jul 31, 2017

@bgruening bgruening merged commit 98292a0 into galaxyproject:dev Aug 1, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 1, 2017

Thanks @mvdbeek!

@mvdbeek mvdbeek deleted the mvdbeek:shutil_rmtree_headache branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.