Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Galactic Radio Telescope Update #4376
replaces #2768. Many changes and optimisations:
Updated backend is available, but it is quite boring. Just accepts reports, and then processes them offline (on cron), and generates some reports.
There is currently some small problem with "share_toolbox" so I've defaulted it to false. Having the full toolbox is less important but still a useful thing to collect since we can produce useful reports for admins. I will patch this in a future PR, but it is not a blocking issue for this one I believe.
Aug 7, 2017
5 checks passed
Thanks for the update and continued work on this @erasche - I look forward to great things!
One thing I'd like to see is that if we are claiming to block certain parameters that we provide a test case to verify this blocking is in fact happening and doesn't get broken at some point. Especially given the complexity of nested parameters and such. Just something to think about for future development.
Thanks again though!
I think you should be able to setup an API test that runs a bunch of jobs and then calls the script to generate the data dump directly from the API test - use the path to the test case Python file to find galaxy_root and then append the scripts directory - call Python directly against that script after setting up test files to target the test setup. I'm not sure things need to be refactored. It might be more complicated than that - I don't know - but it seems straight forward at first glance. Integration tests allow more customization of Galaxy's config prior to starting up Galaxy - so if it is more complicated than an API test allows and you needed to target that directly you could think about doing it there.