Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test tool for API tests #4380

Merged
merged 2 commits into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Aug 7, 2017

This file is required to run the API test added in #4368.

Thanks for catching that @nsoranzo !

<description>verifies identifier source can be specified from input</description>
<command>
<![CDATA[
cat $inputA $inputB > outputA &&

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 7, 2017

Member

outputA -> $outputA

<command>
<![CDATA[
cat $inputA $inputB > outputA &&
cat $inputA $inputB > outputA

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 7, 2017

Member

Can you single-quote inputs and outputs?
Also, on this line I suppose outputA should be $outputB

@jmchilton jmchilton merged commit 3e1b46f into galaxyproject:dev Aug 7, 2017

5 checks passed

api test Build finished. 280 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

Thanks for the catch @nsoranzo and the fix @mvdbeek and the review @nsoranzo and the fix for the fix @mvdbeek !

@mvdbeek mvdbeek deleted the mvdbeek:tie_down_collection_matcher branch Jun 12, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.