Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop loading tools that require a newer galaxy #4382

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@mvdbeek
Copy link
Member

commented Aug 7, 2017

We look at a tools profile attribute, and if it is too new we will not load the tool. This is a first step towards #2086

We should also warn admins prominently that these tools will not load into the tool panel when installing from the tool shed (which is the harder part ...).

Stop loading tools that require a newer galaxy
We look at a tools profile attribute, and if it is too new we will not
load the tool. This is a first step towards
#2086

@mvdbeek mvdbeek changed the title [WIP] Stop loading tools that require a newer galaxy Stop loading tools that require a newer galaxy Aug 7, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2017

I guess this is a nicely atomic PR, I can add the UI aspect in another PR if someone feels like merging.

@mvdbeek mvdbeek added status/review and removed status/WIP labels Aug 7, 2017

@galaxybot galaxybot added this to the 17.09 milestone Aug 7, 2017

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

Cool! Your PRs are awesome!

@bgruening bgruening merged commit 6e37bc0 into galaxyproject:dev Aug 7, 2017

5 checks passed

api test Build finished. 280 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:enforce_tool_profiles branch Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.