Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ensure task splitting handles before job resolution. #4383

Merged
merged 3 commits into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Aug 7, 2017

Fixes #4381 I think.

@@ -66,15 +66,22 @@ def build_command(
if not commands_builder.commands:
return None

# Version, dependency resolution, and task splitting are prepended to the
# command - so they need to appear in the following order to ensure that
# the underlying application used by version command is available in the

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Aug 7, 2017

Member

s/available in the after dependency resolution/after dependency resolution/

@mvdbeek

mvdbeek approved these changes Aug 7, 2017

@galaxybot galaxybot added this to the 17.09 milestone Aug 7, 2017

@mvdbeek mvdbeek merged commit a001145 into galaxyproject:dev Aug 9, 2017

5 checks passed

api test Build finished. 280 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

Thanks @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.