Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show minimum required galaxy version in tool shed and galaxy installation process #4386

Merged

Conversation

Projects
None yet
4 participants
@mvdbeek
Copy link
Member

commented Aug 8, 2017

This requires a metadata reset on the toolshed side (or updating a repository by uploading a new revision). This doesn't prevent an admin from installing the tools, but at least the information is clearly visible.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2017

screen shot 2017-08-08 at 12 07 20 pm

@@ -438,6 +439,7 @@ def build_tools_folder( self, folder_id, tool_dicts, repository, changeset_revis
name='Name',
description='Description',
version='Version',
profile='Minimum required Galaxy version',

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 8, 2017

Member

Maybe this can be shortened to 'Minimum Galaxy version'.

@nsoranzo nsoranzo changed the title Show minimum required galaxy version in tool shed and galaxy installa… Show minimum required galaxy version in tool shed and galaxy installation process Aug 8, 2017

@jmchilton jmchilton merged commit ff197fe into galaxyproject:dev Aug 8, 2017

5 checks passed

api test Build finished. 280 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 8, 2017

More than ever we need a cron job that just triggers a metadata recalculation for every repo every day 😓.

Looks very nice - thanks a ton @mvdbeek!

@mvdbeek mvdbeek deleted the mvdbeek:display_minimum_required_galaxy_version branch Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.