Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize allow_library_path_paste to allow_path_paste. #4404

Merged
merged 2 commits into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Aug 9, 2017

Enable pasting paths in the history upload GUI & general purpose tools API for admin users if enabled.

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

So we can provide planemo with a file:// uri to start workflows?

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2017

@bgruening This work is toward a similar end for sure - I'm trying to run some large workflows through Planemo and I can't even get the datasets to load - this should help significantly I hope.

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

I guess for running workflows from planemo it would be also nice to make use of the linking dataset functionality - and not need to copy the data - iff on the same host.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2017

@bgruening Fair point - that would be even more efficient. Is this "interface" still good or should I implement that as an option before this gets merged so we can reason about everything all together?

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

This is great as it is! Thanks.
I was just thinking that you are working on the planemo run wf.ga --input_1 foo.fq idea and that linking would be also nice.

@galaxybot galaxybot added this to the 17.09 milestone Aug 9, 2017

jmchilton added some commits Aug 9, 2017

Generalize allow_library_path_paste to allow_path_paste.
Enable pasting paths in the history upload GUI & general purpose tools API for admin users if enabled.

@jmchilton jmchilton force-pushed the jmchilton:allow_path_paste branch from 580df89 to f97efa6 Aug 10, 2017

@martenson martenson merged commit cca00ea into galaxyproject:dev Aug 11, 2017

5 checks passed

api test Build finished. 280 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 153 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Oct 6, 2017

Tests for blocking path pastes and intranet URLs for secondary files...
... during upload.

xref galaxyproject#4289 (blocking intranet URLs by default)
xref galaxyproject#4404 (implementing path pastes for normal uploads with the file:// prefix).
xref galaxyproject#4417 (initial tests for blocking file:// prefixes for non-admins added in galaxyproject#4404)

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Oct 6, 2017

Tests for blocking path pastes and intranet URLs for secondary files...
... during upload.

xref galaxyproject#4289 (blocking intranet URLs by default)
xref galaxyproject#4404 (implementing path pastes for normal uploads with the file:// prefix).
xref galaxyproject#4417 (initial tests for blocking file:// prefixes for non-admins added in galaxyproject#4404)

Rebased with a small fix thanks to the ever vigilant @nsoranzo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.