Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin grid groups revision #4405

Merged
merged 24 commits into from Aug 15, 2017

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Aug 9, 2017

Removes grid and form makos used for the admin grid group handling. Branched from #4385.

'status' : 'info',
'inputs' : [ build_select_input( 'groups', 'Groups', all_groups, in_groups ),
build_select_input( 'users', 'Users', all_users, in_users ) ] }
return { 'message' : 'Not showing associated datasets, there are too many.', 'info' : 'info' }

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Aug 14, 2017

Member

This line is unreachable.

This comment has been minimized.

Copy link
@guerler

guerler Aug 14, 2017

Author Contributor

Thanks for catching that @mvdbeek.

@martenson
Copy link
Member

left a comment

I think the select/unselect all (roles/users) feature does not make much sense in this context, and neither does 'save settings' button, when creating a group.

I assume these changes are in place because of the toolformication of these forms, which is planned to be temporary so I guess I am ok with this even though I would prefer to not have these slightly confusing changes in the UI.

@martenson martenson merged commit 4bddd61 into galaxyproject:dev Aug 15, 2017

5 checks passed

api test Build finished. 281 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 153 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2017

Thanks @martenson. Changing the title and/or hiding the select all field is easy to do. I will add it in a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.