Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Excel97 Datatype #4410

Merged
merged 7 commits into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Aug 10, 2017

Extension of #4200 that fixes Mac OS X compatibility and addressed Dan's concern about spaces in filenames. Merging this will merge #4200 as well.

FredericBGA and others added some commits Jun 16, 2017

Refine new Excel XLS datatype.
- Call it excel.xls so we maintain backward compatiblity with older xls datatype.
- Add an example file with a sniff test.
- Correct variable name for Python styling.
- Quote paths when using file command-line trick to sniff for the new type.
- Switch file command-line flag to one that produces the Mimetype on both Linux and Mac OS X.

def set_peek( self, dataset, is_multi_byte=False ):
if not dataset.dataset.purged:
dataset.peek = "Microsoft Excel 2003 file"

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 10, 2017

Member

s/2003/97/ ? Also below.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Aug 11, 2017

Author Member

I can't tell if 2003 or 97 is better - maybe I'll just go with "Microsoft Excel XLS file" - https://msdn.microsoft.com/en-us/library/office/gg615597(v=office.14).aspx.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 11, 2017

Member

maybe I'll just go with "Microsoft Excel XLS file"

Sounds good.

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 11, 2017

This might also help: https://bioportal.bioontology.org/ontologies/EDAM/?p=classes&conceptid=http%3A%2F%2Fedamontology.org%2Fformat_3468
Can we also add the EDAM annotation of this datatype?

@bgruening bgruening merged commit c6e45e7 into galaxyproject:dev Aug 11, 2017

5 checks passed

api test Build finished. 280 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 153 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.