Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Add missing chemical formats to datatypes_conf.xml.sample #4413

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

commented Aug 10, 2017

Missed in #1941 and #2452 .

@nsoranzo nsoranzo added this to the 17.09 milestone Aug 10, 2017

@nsoranzo nsoranzo requested a review from bgruening Aug 10, 2017

@bgruening
Copy link
Member

left a comment

Nice!

nsoranzo added some commits Aug 11, 2017

Update pin for flake8-docstrings
Similar to commit 2586df4 .
@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2017

I had to:

  • pin flake8-docstrings to fix py27-lint-docstring-include-list test
  • backport 4273435 to fix boto/boto#3717 in py27-unit tests.
@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2017

The failed ToolShed test has been disabled in commit 371d277 for 17.05, I don't think it makes sense to backport it.

@mvdbeek mvdbeek merged commit 0f5ad34 into galaxyproject:release_17.01 Aug 14, 2017

4 of 5 checks passed

toolshed test Build finished. 580 tests run, 0 skipped, 1 failed.
Details
api test Build finished. 261 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 27 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:release_17.01_really_add_datatypes branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.