Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Don't cast tool_version to string if tool_version is None-type #4420

Merged

Conversation

Projects
None yet
4 participants
@mvdbeek
Copy link
Member

commented Aug 13, 2017

If a version is not specifically requested a wrong version (None cast to
'None') of a tool will be loaded in the workflow editor instead of the
latest version.

That should address @martenson's remark in
#4373 (comment)
(and maybe also
#557 (comment)).

Don't cast tool_version to string if tool_version is None-type
If a version is not specifically requested a wrong version (`None` cast to
`'None'`) of a tool will be loaded in the workflow editor instead of the
latest version.

That should address @martenson's remark in
#4373 (comment)
(and maybe also
#557 (comment)).
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Aug 13, 2017

LGTM, but there's a failed ToolShed test that may be related.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 13, 2017

Maybe explicitly check for None - I'm not sure what is up with the failing test.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2017

I think this is a problem with an outdated ToolVersionCache when loading a tool outside of the regular toolbox, i.e to display tool metadata in the admin section, as we do in this test. I don't think this is a critical bug to fix, I don't think this will happen outside of testing, and the ToolVersionCache` is gone in dev.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2017

The failing test should be addressed by 6ad6fd9 (but it's not pretty ...)

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

👍

@jmchilton jmchilton merged commit 7f78ee7 into galaxyproject:release_17.05 Aug 15, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 15, 2017

Awesome sauce - thanks!

@mvdbeek mvdbeek deleted the mvdbeek:fix_wrong_tool_version_cast branch Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.