Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break connection in workflow editor if necessary #4431

Merged
merged 1 commit into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Aug 15, 2017

When switching tool versions in the workflow editor connections are
maintained by default. If a tool changes the datatype one may end up
with a connection between incompatible input/outputs. Therefore we
update the datatypes and explicitly destroy invalid connections.

Break connection in workflow editor if necessary
When switching tool versions in the workflow editor connections are
maintained by default. If a tool changes the datatype one may end up
with a connection between incompatible input/outputs. Therefore we
update the datatypes and explicitly destroy invalid connections.

@mvdbeek mvdbeek added this to the 17.09 milestone Aug 15, 2017

@mvdbeek mvdbeek closed this Aug 15, 2017

@mvdbeek mvdbeek reopened this Aug 15, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

Interesting, no tests are picked up ... :/

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@galaxybot test this

1 similar comment
@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@galaxybot test this

@jmchilton jmchilton merged commit 8eb487e into galaxyproject:dev Aug 16, 2017

5 checks passed

api test Build finished. 281 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 153 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

Great - thanks for the fix @mvdbeek !

@mvdbeek mvdbeek deleted the mvdbeek:break_connections branch Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.