Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
changed the title from
Aug 16, 2017
There was conversation in #galaxyproject about whether or not we want to go with a 4-space or 2-space tab stop, with @martenson and @jxtx primarily. I think it was agreed that we need to have a standard and enforce it, but it seems like there are arguments for both 2 and 4. This PR currently enforces a 4-space tab standard, following the trend of much of our existing JS style, and our Python code style. That's easily removed by stripping 0669e78, but I think that what is presented here is a good starting point.
The best news is that with Prettify it's trivial to swap, should we change our mind down the road.
What I was requesting was a clean PR that just modified the code formatting - maybe after the build pipeline was in place (?) - so maybe a PR to setup the new build system and then a second afterward that actually builds the artifacts and modifies the formatting of the files. This still seems to mix Makefile changes, babel configuration, gulpfile addition, etc... in with the formatting changes. Github won't even load the list of all changed files for me. Like I said before though - it isn't feasible that is fine - it'd just help me grok the changes.