Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for advanced grid search #4449

Merged
merged 3 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Aug 17, 2017

Follow-up on #4411.

So there are few items left after merging:

  • When using the advanced search, after triggering, the advanced search should not switch to the normal search.

  • When switching between grids the search terms should not stick.

  • Multiple same searchterms should not be allowed.

Thanks @martenson.

@guerler guerler added this to the 17.09 milestone Aug 17, 2017

@guerler guerler added status/review and removed status/WIP labels Aug 17, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 17, 2017

thanks @guerler !

@martenson martenson merged commit 706741f into galaxyproject:dev Aug 17, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 281 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.