Join GitHub today
Uniform indentation of multiline if conditionals #4455
Use 8-spaces indentation for the conditional continuation lines of
According to PEP-8, using 4-spaces "can produce a visual conflict with the indented suite of code nested inside the
There were only 2 places in the whole codebase where 8 spaces were not used, this will make it uniform.
I think the first one you fixed here is less readable, vertical alignment is more important to me. In my opinion, the best fix is extra indentation in child blocks when this is a problem, not offsetting the vertical alignment of the conditionals.
That said, I feel like I'm in the minority here, it's not something I'd -1 anyway, and you bundled all those other changes, too, so, merging.