Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed sentry reports #4457

Merged
merged 2 commits into from Aug 18, 2017

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

commented Aug 18, 2017

Currently

auswahl_022

  • top right shows "0 users"
  • limited info
  • only tags are level / server

auswahl_023

  • stderr/stdout/cli are all truncated

Now!

auswahl_019

  • complete messages
  • tagged by tool ID / version letting you filter sentry reports on these facets
  • filter on bugs affecting specific users (it shows id here, but in latest version of this it will use email)
  • includes URL to the show_params route for further investigating (or if this report doesn't include enough)

auswahl_020

  • clickable URLs to galaxy

auswahl_021

  • list of affected users functions

erasche added some commits Aug 18, 2017

@erasche erasche added this to the 17.09 milestone Aug 18, 2017

@erasche erasche requested a review from dannon Aug 18, 2017

@bgruening
Copy link
Member

left a comment

Thanks @erasche!

'stdout': unicodify(job.stdout),
'handler': unicodify(job.handler),
'tool_id': unicodify(job.tool_id),
'tool_version': unicodify(job.tool_version),

This comment has been minimized.

Copy link
@bgruening

bgruening Aug 18, 2017

Member

unicodify is probably not needed here but it guess if can not hurt either

@jmchilton jmchilton merged commit cd22de1 into galaxyproject:dev Aug 18, 2017

6 checks passed

api test Build finished. 281 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

Awesome - thanks!

@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

I didn't see there was an outstanding requested review from @dannon - sorry about that - I should have checked that out first.

@dannon

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

I looked at it earlier and it read fine to me, I just hadn't actually tested it yet. No worries.

@erasche erasche deleted the erasche:sentry-extra-info branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.