Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer tool click targets for base + "plain" theme #4470

Merged
merged 4 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@erasche
Copy link
Member

commented Aug 21, 2017

Something quite useless I worked on over the weekend.

  • nicer click targets for base theme. There's a slightly darker hover colour, and clicking anywhere in that area results in the tool link being activated. This is significantly nicer than trying to click a short tool name (sometimes 3-4 characters) vs a large, unclickable description (10-100 chars)
    auswahl_032
  • plain theme screenshots follow. Can be enabled by uncommenting the theme in galaxy_variables.less

auswahl_025
auswahl_027
auswahl_029
auswahl_030

erasche added some commits Aug 20, 2017

@erasche erasche force-pushed the erasche:retheme branch from 27055e1 to 97ee0f1 Aug 25, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Aug 28, 2017

The larger click targets are a good idea. The plain theme is definitely not for me, but it's nice to include it as another demonstration of how one might make their own theme.

@dannon dannon merged commit 4b9b149 into galaxyproject:dev Aug 28, 2017

6 checks passed

api test Build finished. 284 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@bgruening bgruening deleted the erasche:retheme branch Aug 28, 2017

@erasche erasche referenced this pull request Mar 1, 2019

Merged

Add tool hover #7437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.