Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needed for sentry functionality in reports webapp #4471

Merged
merged 3 commits into from Aug 25, 2017

Conversation

Projects
None yet
2 participants
@erasche
Copy link
Member

commented Aug 21, 2017

No description provided.

@dannon

This comment has been minimized.

Copy link
Member

commented Aug 25, 2017

@erasche If you're feeling ambitious, I think there are a few #TODOs to refactor this into a shared configuration module instead of having it in each webapp's config directly. Reports definitely does need access to this to run sentry, though, so merging.

(I spoke too soon, tests are legit, linting needs a few fixes -- opened a PR for them at erasche#19)

dannon and others added some commits Aug 25, 2017

Merge pull request #19 from dannon/reports-sentry-dsn
Fixes for reports sentry dsn (lint and missing import).
@erasche

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2017

Thanks for the PR @dannon, sorry, had completely forgotten about this PR.

Agreed, more or less, about general refactoring, but I'd rather see people replace reports with grafana + statsd ;) this was an interim solution for us until we can get all of the metrics we want pushed / dashboards built.

@dannon dannon merged commit df0507e into galaxyproject:dev Aug 25, 2017

6 checks passed

api test Build finished. 284 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.