Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /mobile and associated templates #4494

Merged
merged 3 commits into from Aug 24, 2017

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented Aug 24, 2017

I stumbled across this when updating/locking/removing libraries (specifically jQtouch, which is dead) for #4435. This endpoint has been effectively deactivated for almost three years now, and if we're approaching mobile again it won't be with custom templates for each endpoint, etc.

If folks really want, I'll add a route/redirect, but I really don't think we need to at this point.

(I left the mobile styles thinking that's actually something we might want to work with moving forward, but none of this would be useful)

@dannon

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2017

After looking more, the styles require resources that aren't even there, and we'd do that differently in the future as well. One more change coming, then I'll flag this for review.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2017

Ok, I went ahead and pulled jQtouch out as well to make this a comprehensive PR removing all of the related materials here. Ready for a second look and a merge, thanks @nsoranzo and @guerler!

@jxtx

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2017

Definitely kill all of this.

@galaxybot galaxybot added this to the 17.09 milestone Aug 24, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 24, 2017

This kills urls, but after ~3 years of deprecation I think that is fine. Thanks @dannon !

@martenson martenson merged commit 1426225 into galaxyproject:dev Aug 24, 2017

4 of 6 checks passed

api test Build finished. 284 tests run, 0 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript 2 fixed alerts
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.