Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017-08 Security Patch #4501

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@erasche
Copy link
Member

commented Aug 28, 2017

Secure two webapp vulnerabilities.

Firstly, improve sanitization of HTML content for job generated files.

  • Sanitize sub-directory files.
  • Sanitize filenames in HTML index pages.
  • Don't pre-read content if not going to sanitize - just hand off to web server.

This exploit was reported by Eric Rasche (@erasche).

Secondly, prevent URL redirection hijacking if certain query parameters happen to contain newlines or carriage returns.

This issue was reported by Manabu Ishii (@manabuishii).

@galaxybot galaxybot added the triage label Aug 28, 2017

@galaxybot galaxybot added this to the 17.09 milestone Aug 28, 2017

@martenson martenson merged commit f159df3 into galaxyproject:dev Aug 28, 2017

6 checks passed

api test Build finished. 284 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.