Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and clarifications for composite uploads. #4505

Merged
merged 2 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Aug 28, 2017

  • Add an API test for datatype-defined composite uploads - including exercising newline conversion and the space_to_tab parameter.
  • Add a test decorator skip_without_datatype to mirror skip_without_tool for this test, improve both decorators.
  • The ftype parameter in the composite test tools does nothing - drop it and drop it from the XSD spec.
  • Slightly improve the documentation for these composite_data elements in the XSD.
  • The first commit that enables the testing described above (10742e4) by aggregating various populators.py refactoring from the CWL branch.

@galaxybot galaxybot added this to the 17.09 milestone Aug 28, 2017

@jmchilton jmchilton force-pushed the jmchilton:composite_upload_refine branch 2 times, most recently from d9206ab to 14a580c Aug 28, 2017

jmchilton added some commits Aug 28, 2017

Test and clarifications for composite uploads.
- Add an API test for datatype-defined composite uploads - including exercising newline conversion and the space_to_tab parameter.
- Add a test decorator skip_without_datatype to mirror skip_without_tool for this test, improve both decorators.
- The ftype parameter in the composite test tools does nothing - drop it and drop it from the XSD spec.
- Slightly improve the documentation for these composite_data elements in the XSD.
Break up populator methods for greater composibility and reuse.
All of these changes are needed for various downstream enhancements I'm working on for things like CWL support and extra file testing - but I think they should all be okay refactorings on their own.

@jmchilton jmchilton force-pushed the jmchilton:composite_upload_refine branch from 14a580c to 5a7a15d Aug 31, 2017

@martenson martenson merged commit 9b4cd09 into galaxyproject:dev Sep 5, 2017

6 checks passed

api test Build finished. 287 tests run, 3 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.