Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Prevent transient job state test failures from failing the build. #4510
A precondition to the real meat of the test is failing to be met sometimes in production - this failure is indicating a problem with the test and not with Galaxy. I previously tried to address this with #3988 but that didn't work. Now if the trainsient ok occurs the test will be skipped. Most of the time it won't skip and the rest of the test will execute and ensure there aren't regressions in behaviors related to cleaning up datasets after job completion. I'm placing the skips a couple different places so hopefully we can get a stack trace at some point - knowing where the code is when the job state is changing from running to ok will help puzzle out what is handing for the two minutes the job is running in the test framework.
The tool it is using sleeps for 120 seconds - looking at the timing I think it is actually sleeping for 120 seconds also. I think that part is working as far as I can tell. Just something in the test is occasionally taking more than that - possibly something is blocking on the state of the job to change somehow?