Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium test fixes and improvements. #4523

Merged
merged 2 commits into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Aug 30, 2017

More logging for selenium tests.

Dump the browser log and the driver log out as JSON to the test error directory for that test.

Fix and Improve setting up Sizzle for Selenium tests.

Something related to AMD broke our way of injecting Sizzle into Galaxy for Selenium tests. This is a much better way that seems to work - just use jQuery ($) as Sizzle if it is available. Avoids an external dependency and another page fetch per test as well as fixing the problem.

Add a test case that just tests the sizzle stuff works on its own. It will be a clear indication what is broken if there are related regressions in the future.

jmchilton added some commits Aug 30, 2017

More logging for selenium tests.
Dumb the browser log and the driver log out as JSON to the test error directory for that test.
Improve setting up Sizzle for Selenium tests.
Something releated to AMD broke our way of injecting Sizzle into Galaxy for Selenium tests. This is a much better way that seems to work - just use jQuery ($) as Sizzle if it is available. Avoids an external dependency and another page fetch per test as well as fixing the problem.

Add a test case that just tests the sizzle stuff works on its own. It will be a clear indiciation what is broken if there are related regressions in the future.
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2017

@galaxybot test this

@bgruening bgruening merged commit d09ced2 into galaxyproject:dev Aug 31, 2017

6 checks passed

api test Build finished. 284 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 31, 2017

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.