Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow run Selenium test and make it more robust. #4524

Merged
merged 2 commits into from Sep 3, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Aug 30, 2017

This test went from transiently broken to always broken during this release cycle. This PR makes two changes to try to fix both of those conditions. It correct the frame and button Selector for the new workflow run UX for the newer error and this allows explicitly refreshing the browser when waiting for datasets to appear to deal with the transient problems.

@jmchilton jmchilton added this to the 17.09 milestone Aug 30, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Aug 31, 2017

Another fix for Selenium worklow tests.
This time for the workflow upgrade message test, mirrors the fix in galaxyproject#4524 - the content we are searching for in on this page is no longer in the iframe.
template = "Failed waiting on history item %d to become visible, visible datasets include [%s]."
message = template % (hid, ",".join(div_ids))
raise self.prepend_timeout_message(e, message)
for i in range(3):

This comment has been minimized.

Copy link
@bgruening

bgruening Aug 31, 2017

Member

Should this be configurable with the allow_refresh param?

This comment has been minimized.

Copy link
@jmchilton

jmchilton Aug 31, 2017

Author Member

Yeah... my logic is a little off here isn't it?

This comment has been minimized.

Copy link
@jmchilton

jmchilton Aug 31, 2017

Author Member

Or I guess you are saying this should be parameterized instead of 3 - yeah I'll make a couple quick changes to this.

jmchilton added some commits Aug 30, 2017

Fix workflow run Selenium test and make it more robust.
This test went from transiently broken to always broken during this release cycle. This PR makes two changes to try to fix both of those conditions. It correct the frame and button Selector for the new workflow run UX for the newer error and this allows explicitly refreshing the browser when waiting for datasets to appear to deal with the transient problems.
Fix "all" vs. "ALL" in Selenium logging configuration.
The previous value broke all the tests on Jenkins.

@jmchilton jmchilton force-pushed the jmchilton:selenium_fixes_16 branch from 6b4f86c to edd3b07 Sep 1, 2017

@bgruening bgruening merged commit ea9f5f7 into galaxyproject:dev Sep 3, 2017

6 checks passed

api test Build finished. 284 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.