Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test modules toward cleaner dependencies #4536

Merged
merged 6 commits into from Sep 3, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Sep 1, 2017

  • Refactor base.twilltestcase.FunctionalTestCase out into a base.testcase.FunctionalTestCase that has no dependencies on Twill at all.
  • Move base.twilltestcase into functional.twilltestcase - so that nothing in base has a dependency on Twill.
  • Eliminate some hacks and unused tests to further simplify dependencies.

The ultimate goal I guess is to simplify dependencies to the point that it is possible to run Selenium, API, and Tool tests without any dependency on Galaxy proper. When they can be run in that fashion - hopefully we can create PyPI modules for testing Galaxy independent of Galaxy itself. After these changes nothing in base has any dependencies on anything in the test framework or Galaxy itself outside of galaxy-lib except base.driver_util - so we are closer to this goal.

@galaxybot galaxybot added this to the 17.09 milestone Sep 1, 2017

@jmchilton jmchilton force-pushed the jmchilton:test_refactoring branch from 9ba0628 to 3ae305f Sep 1, 2017

jmchilton added some commits Sep 1, 2017

Continue separation of FunctionalTestCase from TwillTestCase.
Move non-twill stuff out into its own module including FunctionalTestCase.
Remove test/functional/test_library_templates.py.
Hasn't been run in forever and it seems like we are deprecating these features.
Rework hack to inject database contexts into Tool Shed tests.
Rather than depend on something in ``functional`` test module from ``base.driver_util``, just set these global hacks up in ``driver_util`` itself. This eliminates a dependency of ``functional`` on ``base`` - ideally ``base`` would not depend on any other test modules.
Move twilltestcase from ``base`` to ``functional`` module.
This way nothing in ``base`` has any dependencies on Twill anymore.

@jmchilton jmchilton force-pushed the jmchilton:test_refactoring branch from 3ae305f to aba726a Sep 1, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2017

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2017

Last set of tests failed because the shed was down.

@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 3, 2017

Awesome! Looking forward to run more test in Docker!

@bgruening bgruening merged commit b2ceef5 into galaxyproject:dev Sep 3, 2017

6 checks passed

api test Build finished. 284 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the jmchilton:test_refactoring branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.