New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial selenium tests for libraries. #4543

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Sep 4, 2017

  • Test importing datasets from histories.
  • Test basic importing of a dataset from a path.
  • Test creating a folder.
  • Test create library, renaming a library, filtering libraries by name, and sorting of libraries.
  • Test various buttons (e.g. details, help).
@martenson

This comment has been minimized.

Member

martenson commented Sep 5, 2017

Awesome! 🎉

@martenson

This comment has been minimized.

Member

martenson commented Sep 5, 2017

this might need a rebase to get rid of a91c03d

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 5, 2017

Thanks @martenson - will do.

I have admit I spent a couple more hours on this last night and I still cannot get this working consistently. The biggest problem is that I cannot get the search box to work in Selenium. The search box for the published histories grid just works with selenium's send_keys(text) method - but the keyUp handler that libraries uses don't seem to recognize this. I've tried a number of work arounds - I'll keep trying though.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 3, 2017

Rebased on top of #4732 and significantly cleaned up - a lot closer to consistently passing now.

@jmchilton jmchilton changed the title from [WIP] Initial work on selenium testing for libraries. to Initial work on selenium testing for libraries. Oct 3, 2017

@jmchilton jmchilton added status/review and removed status/WIP labels Oct 3, 2017

@jmchilton jmchilton changed the title from Initial work on selenium testing for libraries. to Initial selenium tests for libraries. Oct 3, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 3, 2017

@martenson

This comment has been minimized.

Member

martenson commented Oct 3, 2017

Github is showing some weird diff for this PR

@martenson

This comment has been minimized.

Member

martenson commented Oct 3, 2017

I checked out this branch again and the changes in e.g. client/galaxy/scripts/mvc/history/history-view.js are still there (comapred to up-to-date dev). That feels wrong?

Initial work on selenium testing for libraries.
- Test importing datasets from histories.
- Test basic importing of a dataset from a path.
- Test creating a folder.
- Test create library, renaming a library, filtering libraries by name, and sorting of libraries.
- Test various buttons (e.g. details, help).
@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 3, 2017

Rebased and the diff is much cleaner now.

@martenson martenson merged commit 4a58433 into galaxyproject:dev Oct 3, 2017

6 checks passed

api test Build finished. 297 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Oct 3, 2017

splendid, thanks a lot @jmchilton !

@galaxybot

This comment has been minimized.

galaxybot commented Mar 7, 2018

This PR was merged without a 'kind/' tag, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment