Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check user roles only once if user has no roles #4546

Merged
merged 1 commit into from Sep 4, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Sep 4, 2017

The previous implementation in #4541 would check user roles multiple
times if a user has no roles.

Noticed by @nsoranzo, many thanks!

Check user roles only once if user has no roles
The previous implementation in #4541 would check user roles multiple
times if a user has no roles.

Noticed by @nsoranzo, many thanks!

@nsoranzo nsoranzo merged commit 003344a into galaxyproject:dev Sep 4, 2017

6 checks passed

api test Build finished. 286 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@erasche erasche referenced this pull request Sep 7, 2017

Open

[RFC] Caching Framework #4571

@mvdbeek mvdbeek deleted the mvdbeek:tool_form_followup branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.