Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow linking, posix and spaces conversions in datalib imports #4547

Merged
merged 2 commits into from Sep 5, 2017

Conversation

3 participants
@martenson
Copy link
Member

commented Sep 4, 2017

closes #2977

closes #1529

* @param {array} paths paths relative to Galaxy root folder
* @param {boolean} preserve_dirs indicates whether to preserve folder structure
* @param {boolean} link_data copy files to Galaxy or link instead
* @param {boolean} to_posix_lines copy files to Galaxy or link instead

This comment has been minimized.

Copy link
@dannon

dannon Sep 5, 2017

Member

Comment should be updated here probably (copied from above when editing, looks like)

This comment has been minimized.

Copy link
@martenson

martenson Sep 5, 2017

Author Member

resolved, thanks!

@martenson

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2017

So, make client has no output on comment changes...but shouldn't it build a new map?

@martenson martenson added this to Done in Data Libraries Sep 5, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

@martenson I read through https://sourcemaps.info/spec.html and it seems to me like the mapping offsets should stay the same when only the comments change like that, so this looks good to me.

@martenson

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2017

@dannon kudos to them, good design

@dannon dannon merged commit 3aacbdf into galaxyproject:dev Sep 5, 2017

6 checks passed

api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson moved this from Done to Closed in Data Libraries Sep 6, 2017

@martenson martenson deleted the martenson:library-import-conversions branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.