Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Selenium test fixes #4549

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Sep 5, 2017

Three commits, three fixes...

jmchilton added some commits Sep 5, 2017

Update the default testing Selenium Chrome Docker target.
Some recent changes was incompatible with some bug in the older version (possibly this bug https://bugs.chromium.org/p/chromedriver/issues/detail?id=1552), the result is a huge number of failures in Jenkins as some persistent session error occurs. For example the older (https://jenkins.galaxyproject.org/job/selenium/209/testReport/) but with me hacking the Jenkins job to make this change only two tests fail (https://jenkins.galaxyproject.org/job/selenium/210/testReport/).
Possible fix for a transient failure in the published histories grid …
…tests.

See failure here (https://jenkins.galaxyproject.org/job/selenium/210/testReport/selenium_tests.test_published_histories_grid/HistoryGridTestCase/test_history_grid_sort_by_owner/).

Uses technique to retry atomic assertions that may not be immediately true but will settle as the DOM is updated in response to changes to be true (added in d0df388).
Remove Selenium test that is broken because Galaxy is broken.
See (#4548) for more information on the underlying issue.

@galaxybot galaxybot added this to the 17.09 milestone Sep 5, 2017

@bgruening bgruening merged commit 3962ba9 into galaxyproject:dev Sep 5, 2017

6 checks passed

api test Build finished. 289 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

Works for us! @jmchilton if you keep up this speed we can enable them in 17.09 :)

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

The third commit shouldn't have been included, since galaxy is fixed. I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.