Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tools wf editor alternative #4552

Merged

Conversation

Projects
None yet
4 participants
@mvdbeek
Copy link
Member

commented Sep 5, 2017

This should fix #4548.

@nsoranzo

This comment has been minimized.

Copy link
Collaborator

commented on lib/galaxy/managers/workflows.py in 686cb48 Sep 5, 2017

There's an extra space in %s. "

@@ -617,9 +617,6 @@ def from_workflow_step(Class, trans, step, **kwds):
if message:
log.debug(message)
module.version_changes.append(message)
else:
# The tool is not installed
raise ToolMissingException("Tool %s missing. Cannot build workflow module." % tool_id)

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Sep 5, 2017

Member

Maybe log something?

@galaxybot galaxybot added this to the 17.09 milestone Sep 5, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

Awesome - thanks @nsoranzo and @mvdbeek!

@jmchilton jmchilton merged commit af9173d into galaxyproject:dev Sep 5, 2017

2 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:fix_missing_tools_wf_editor_alternative branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.