Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting workflows when tool is uninstalled #4553

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Sep 5, 2017

I'm sorry for all these small PRs on the same topic, but @guerler mentioned here that it may be possible to export workflows with tools that are not currently installed.

What I have tested is creating a workflow with hisat2 (single end, and flipped one parameter) and a downstream and upstream cat1 tool. When I remove hisat2, I can still download the workflow. Importantly, when I re-import the workflow and then re-install hisat2 the workflow is properly connected and the custom parameters are still set.

@mvdbeek mvdbeek added this to the 17.09 milestone Sep 5, 2017

@mvdbeek mvdbeek requested a review from guerler Sep 5, 2017

@mvdbeek mvdbeek force-pushed the mvdbeek:allow_exporting_workflow_with_uninstalled_tools branch from 2af10c7 to bff6b58 Sep 5, 2017

@guerler

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

No worries, small PRs are great. There might be a problem when trying to reimport this workflow into a release before 2017. If we do not have to worry about that then this PR looks good to me. ping @jmchilton.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

I'm sorry for all these small PRs on the same topic

Don't apologize - these are all awesome and I think everyone prefers to look at smaller, atomic PRs!

At any rate - this looks awesome to me. This is a very old and often complained about issue - I tried to fix it one time and failed but I can't find a Github issue (maybe it was on Trello).

@guerler I'm not sure I understand your comment about older Galaxies - but I guess I'm just happy these can be exported to relatively new Galaxies now - since before they could not be exported at all previously.

@jmchilton jmchilton merged commit 65b86e3 into galaxyproject:dev Sep 5, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 289 tests run, 3 skipped, 0 failed.
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:allow_exporting_workflow_with_uninstalled_tools branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.