Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unbound variable error history controller. #4557

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Sep 5, 2017

Fixes #4423 I suppose - thanks @erasche.

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

Will shared_histories potentially have multiple copies of the same history with this change? (have not tested to see if this is a problem, but it looks like it could possibly be, given the data structure listed in the comment above, right?)

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2017

@dannon I think there is an if check to prevent that:

if history not in shared_histories:
    shared_histories.append(history)
@dannon

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

@jmchilton D'oh, of course. Looks good to me. (I looked up, but not down!)

@dannon dannon merged commit 7db47e7 into galaxyproject:dev Sep 5, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.